Repository navigation
chore: run the F5 compile task with the project's pnpm - #123
Conversation
- Change the compile task in .vscode/tasks.json from `npm exec --yes -- pnpm@10.29.3 run compile` to `pnpm run compile` - F5 now uses the pnpm version pinned in package.json (10.34.5) through Corepack, like install, CI, and CONTRIBUTING.md, instead of fetching an older pnpm through npm - Contributors need Corepack enabled for F5, which CONTRIBUTING.md already asks for
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Background and purpose
Pressing F5 ran the compile task with
npm exec --yes -- pnpm@10.29.3, so the development build fetched an older pnpm through npm while install, CI, and the setup inCONTRIBUTING.mduse the pnpm pinned inpackage.json(10.34.5) through Corepack. This came up in the review of #122. This PR makes F5 use the same pnpm as everything else.Changes
compiletask in.vscode/tasks.jsontopnpm run compilePoints to review
CONTRIBUTING.mdalready asks contributors to runcorepack enableCONTRIBUTING.md"Development setup",.vscode/launch.json(preLaunchTask: compile).vscode/tasks.json