Skip to content

chore: run the F5 compile task with the project's pnpm - #123

Merged
numlia merged 1 commit into
mainfrom
chore/vscode-task-corepack
Oct 25, 2026
Merged

numlia merged 1 commit into
mainfrom
chore/vscode-task-corepack

Conversation

@numlia

@numlia numlia commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Background and purpose

Pressing F5 ran the compile task with npm exec --yes -- pnpm@10.29.3, so the development build fetched an older pnpm through npm while install, CI, and the setup in CONTRIBUTING.md use the pnpm pinned in package.json (10.34.5) through Corepack. This came up in the review of #122. This PR makes F5 use the same pnpm as everything else.

Changes

  • Change the compile task in .vscode/tasks.json to pnpm run compile

Points to review

  • F5 now needs Corepack enabled (or pnpm on the PATH). CONTRIBUTING.md already asks contributors to run corepack enable
    • Where to check: CONTRIBUTING.md "Development setup", .vscode/launch.json (preLaunchTask: compile)
  • F5 no longer fetches pnpm from the npm registry on first use, so it also works offline once dependencies are installed
    • Where to check: .vscode/tasks.json

- Change the compile task in .vscode/tasks.json from `npm exec --yes -- pnpm@10.29.3 run compile` to `pnpm run compile`
- F5 now uses the pnpm version pinned in package.json (10.34.5) through Corepack, like install, CI, and CONTRIBUTING.md, instead of fetching an older pnpm through npm
- Contributors need Corepack enabled for F5, which CONTRIBUTING.md already asks for
@numlia numlia self-assigned this Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 90e3c6d and abc0e5b.

Files selected for processing: 1
  • .vscode/tasks.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@numlia
numlia marked this pull request as ready for review October 25, 2026 13:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T13:59:45.273403Z abc0e5b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@numlia
numlia merged commit 5b02690 into main Oct 25, 2026
3 checks passed
@numlia
numlia deleted the chore/vscode-task-corepack branch October 25, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant