[18.0][OU-ADD] ptplus_edi: retire legacy CIUS-PT edi format xmlid before the orphan GC#21
Open
eantones wants to merge 1 commit into
Open
[18.0][OU-ADD] ptplus_edi: retire legacy CIUS-PT edi format xmlid before the orphan GC#21eantones wants to merge 1 commit into
eantones wants to merge 1 commit into
Conversation
eantones
added
the
local-only
…ore the orphan GC The vendor's 18.0 rebuild on account.move.send stops declaring account.edi.format cius_pt_211; _process_end's DELETE is FK-blocked by historical account_edi_document rows + the journal m2m (benign 'bad query' on every fresh run, unfixable from hop-close SQL). Minimal retirement in the module's own namespace, before the GC — same treatment as ptplus's PT-RF CD tags at 16.0 (PR#20).
eantones
force-pushed
the
18.0-ou-add-ptplus_edi
branch
from
July 20, 2026 22:28
40d119c to
2e08c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ptplus_edi18.0.2.0.0 (vendor rebuild onaccount.move.send) stops declaring the legacyaccount_ediframework recordaccount.edi.formatcius_pt_211.base's_process_endorphan cleanup (inside-u all) then firesDELETE FROM account_edi_format WHERE id IN (…), FK-RESTRICT-blocked by historicalaccount_edi_documentrows and the journal m2m → a benign but RED-flaggedbad queryon every fresh run.Why not the hop-close SQL surrogate
The previous fix (instance
versions/18/hop/post.sqldeleting their_model_datarow) runs after-u all— it can only prevent the second firing. On any re-run from a fresh production dump the row is back and the bad query fires again. Superseded by this script.How
Same minimal-retirement treatment as ptplus's PT-RF CD tax tags at 16.0 (#20), in the module's own namespace, in
pre-migration(before the GC):account_edi_formatfrompg_constraint(immune to ON DELETE CASCADE masking);ir_model_data.module = '__ptplus_legacy__'+noupdate(row, links and provenance survive; the GC no longer owns it);Vendor namespace (packaged module, cannot carry its own fix) → local-only, never for OCA upstream.