Skip to content

[18.0][FIX] base: cascade inactive child views on force unlink #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eantones wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] base: cascade inactive child views on force unlink #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions odoo/addons/base/models/ir_ui_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,9 +570,13 @@ def write(self, vals):
return res

def unlink(self):
# if in uninstall mode and has children views, emulate an ondelete cascade
if self.env.context.get('_force_unlink', False) and self.inherit_children_ids:
self.inherit_children_ids.unlink()
# if in uninstall mode and has children views, emulate an ondelete cascade;
# inactive children are hidden by active_test but still hold the inherit_id
# RESTRICT foreign key, which would leave this view orphaned
if self.env.context.get('_force_unlink', False):
children = self.with_context(active_test=False).inherit_children_ids
if children:
children.unlink()
self.env.registry.clear_cache('templates')
return super(View, self).unlink()

Expand Down