Skip to content
This repository was archived by the owner on Jun 24, 2026. It is now read-only.

add workflow to publish package to PyPi - #1

Merged
fj-nurok merged 4 commits into
mainfrom
fj-dev
Dec 26, 2025
Merged

add workflow to publish package to PyPi#1
fj-nurok merged 4 commits into
mainfrom
fj-dev

Conversation

@fj-nurok

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @fj-nurok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Python script that automates the verification of version consistency across key project files. By ensuring that the version from a git tag aligns with the versions specified in pyproject.toml and a2ui_pydantic/__init__.py, this change establishes a robust mechanism to prevent versioning discrepancies, which is crucial for a reliable PyPi publishing workflow.

Highlights

  • New Version Verification Script: A new Python script, scripts/verify_version.py, has been added to the repository.
  • Automated Version Consistency Checks: This script ensures that the version derived from a git tag matches the versions declared in pyproject.toml and a2ui_pydantic/__init__.py.
  • README.md Version Check: It includes an optional, soft check to verify if the version is mentioned within the README.md file.
  • Pre-publish Integrity: The script is designed to serve as a critical pre-publish check, likely within a CI/CD pipeline, to maintain version integrity before publishing the package to PyPi.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov

codecov Bot commented Dec 26, 2025

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script, scripts/verify_version.py, to ensure version consistency across pyproject.toml, a2ui_pydantic/__init__.py, and the git tag. The script is a valuable addition for release automation. My review includes two main points: a high-severity issue where the README version check is currently non-functional, and a medium-severity suggestion to improve the script's command-line behavior by using sys.stderr for error messages. With these changes, the script will be more robust and reliable.

Comment thread scripts/verify_version.py Outdated
Comment thread scripts/verify_version.py Outdated
@fj-nurok

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful script for verifying version consistency across project files. My review focuses on making the script more robust. I've suggested replacing regular expression-based parsing with dedicated parsers like tomllib for pyproject.toml and ast for Python files, which is safer and more maintainable. I also recommended a more precise version check in the README file to avoid potential false positives.

Comment thread scripts/verify_version.py
Comment thread scripts/verify_version.py
Comment thread scripts/verify_version.py
@fj-nurok
fj-nurok merged commit 7587adb into main Dec 26, 2025
2 checks passed
@fj-nurok
fj-nurok deleted the fj-dev branch December 26, 2025 04:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant