[Tan Hin Khai Stephen] iP#454
Open
blackonyyx wants to merge 44 commits into
Open
Conversation
blackonyyx
commented
Aug 28, 2020
blackonyyx
commented
- Duke Prototype Works
- Add Text UI Script Testing
- Add Proposed commands: todo, deadline, event
- Add saving and loading from text files
- Add DukeException Classes
- Enumerated Duke Exception Technical Messages
- Enumerated commands to duke
- Add main loop elements to UI class.
- Add jar file
- Add datetime parsing and autocorrection (Not fully functional)
can now save the tasklist to a textfile. Also added tag for packages that was already done in a previous iteration of the project.
1. Added datetime functionalities to the timed task 2. Added datetime difference to response message by Duke 3. Added String cleaning strip() to Duke inputs. 4. Added new Help Messages 5. Added Autocorrect function using time of initial execution as default datetime. 6. Added Deadlines and Event occurance countdowns from given datetime parsed to the current date.
Merge Branch 7 and Branch 8 into master
1. Refactor Duke.java and ChatboxApplication.java with Mainloop in
ChatboxApplication
This is in order to perform future UI implementations and allow
interfacing between Chatbot back end and front end.
2. Add Text Parser class
This is in order to perform text string parsing for user inputs.
Tested for Expected Exceptions and Expected returns from methods
called
This is due to these classes being most essential for proper
functioning of the main loop and to handle the user input.
1. Add find function
Find function performs a search in the description of each task
This is done using Regex to find matching patterns, rather than just
using CharSequences.
To allow for better code review and understanding by other peer reviewers
as well as javadocs for most methods inside the classes
Added Checkstyle and JavaDocs into IP
This allows for more automated integration of testing and compilation for the production version. Use gradle to refactor and update more documentation for javadocs This allowed better updating of documentations
rtshkmr
reviewed
Sep 1, 2020
rtshkmr
left a comment
rtshkmr
left a comment
There was a problem hiding this comment.
Hi, your code is really nice to read, it's clean and naming is aptly done. Flows really well. Couldn't nitpick on any specific naming violations though. Good job man! 👍
This will make code more readable and comply with the code standards
petrickjerico
left a comment
petrickjerico
left a comment
There was a problem hiding this comment.
Hi, blackonyyx! After reviewing your PR, I found that your code overall looks very neat and clean 👍🏼 I found some library usages that stood as insightful and worth trying out on my own too. The code could use some minor cosmetics, but otherwise, the refactoring is thorough and effective. Kudos!
Add JavaFX for duke application todo: edit the linebreaks and wrappers to get a better display. TODO: Add initial message and username setting
style. Refactor of Commands inside TaskList to the CommandList Library This will prevent TaskManager Class from being overbulked with methods, and modularises command tasks to a functional interface. Refactor of User Interface into a Interface class that is to be used by both GUI and CLI methods of execution.
Refactor of GUI to use GUIHelper class to handle the interface between the backend and front end of script. Proper indentation of most tasks have been performed. Help Command can now support command based help searches.
Minor String Formatting modifications
Create gradle.yml Performed Continuous Integration
Minor Code Formatting modifications
code standards of module.
the state of the project as being completed. User Guide will provide a good reference for enduser to understand how to execute commands and tasks using Duke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.