[Chan Yong Soon, Kendrew] iP#458
Open
KendrewChan wants to merge 53 commits into
Open
Conversation
BobbyZhouZijian
left a comment
BobbyZhouZijian
left a comment
There was a problem hiding this comment.
LGTM. Just some nits to fix.
zyifanz
reviewed
Sep 1, 2020
A-Assertions
A-CodeQuality
C-DetectDuplicates
Contributor
|
This PR should be kept open |
Author
|
Oh okay! Sorry :/
…On Mon, Sep 7, 2020 at 12:52 PM Damith C. Rajapakse < ***@***.***> wrote:
This PR should be kept open
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#458 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKWJY5VD25ZVP7YNRBAY4TSERRI5ANCNFSM4QOYI33A>
.
|
therizhao
reviewed
Sep 11, 2020
therizhao
left a comment
therizhao
left a comment
There was a problem hiding this comment.
Hello Kendrew, I am writing this review for my tutorial class 😄
| /** | ||
| * Sets Status of Task to be done or not. | ||
| * | ||
| * @param checked String "0" to represent false, and "1" for true |
There was a problem hiding this comment.
Hello 😄 . Could you use a boolean for the property done instead? If there are more than 2 states, you could consider using a enum 🔢 . Otherwise all good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.