Skip to content

Conversation

@reinkrul
Copy link
Member

@reinkrul reinkrul commented Feb 6, 2026

Fixes #3991

@qltysh
Copy link

qltysh bot commented Feb 6, 2026

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.01%.

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
vcr/cmd/cmd.go0.0%44
Coverage rating: C Coverage rating: C
vcr/vcr.go100.0%
Coverage rating: A Coverage rating: A
vcr/revocation/types.go100.0%
Coverage rating: A Coverage rating: A
vcr/revocation/statuslist2021_verifier.go100.0%
Total80.0%
🤖 Increase coverage with AI coding...

In the `vcr-configure-revocation-maxage` branch, add test coverage for this new code:

- `vcr/cmd/cmd.go` -- Line 44

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@stevenvegt
Copy link
Member

How does this relates to the validUntil param of the status list itself? This value should imho be credential specific because it really depends on the governance of the credential. If the issuer promises to update the list at least once a week, there is no need to fetch this every time after 15 minutes. Right?

If it is merely a demo/dev thing, perhaps scope it like that and don't allow it in strict-mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VCR: Allow configuration of revocation list max-age

2 participants