Return invalid_request instead of server_error for unknown subjects in /authorize and /token #4003
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The
/authorizeendpoint returnsserver_error(HTTP 500) when the subject is not found, misclassifying a client error as a server error.Changes
subjectExists()to returnoauth.OAuth2ErrorwithInvalidRequestcode instead of rawdidsubject.ErrSubjectNotFoundTestWrapper_subjectExiststo verify OAuth2 error structureImpact
Requests to
/oauth2/{unknown-subject}/authorizenow return:Fixes #3974
Previously returned HTTP 500 with generic
server_errorcode.This aligns with the error handling pattern already used in
OpenIDConfiguration()for the same error condition.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.