-
Notifications
You must be signed in to change notification settings - Fork 108
feat(init): detect agent/CI environments and skip interactive prompts #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atinux
wants to merge
5
commits into
main
Choose a base branch
from
claude/nuxt-cli-agent-support-sTRzI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+198
−77
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
110a396
feat(init): detect agent/CI environments and skip interactive prompts
claude 9244180
fix(init): consolidate non-interactive output before project creation
claude 0f5863c
fix(init): exit after showing options when agent provides no directory
claude fce0445
fix(init): remove redundant isNonInteractive from template loading co…
claude 11bcdb1
[autofix.ci] apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreachable code: this branch can never execute.
In non-interactive mode, if
ctx.args.diris empty (the''default), the code exits early at lines 230-233. Therefore, theisNonInteractivebranch here fordir === ''is dead code since we'd never reach this point with an empty dir in non-interactive mode.This doesn't break anything but adds confusion. Consider removing this branch or adjusting the early exit logic if you want non-interactive mode to auto-select a directory.
🧹 Proposed fix: Remove unreachable branch
let dir = ctx.args.dir if (dir === '') { const defaultDir = availableTemplates[templateName]?.defaultDir || 'nuxt-app' - if (isNonInteractive) { - dir = defaultDir - } - else { - const result = await text({ - message: 'Where would you like to create your project?', - placeholder: `./${defaultDir}`, - defaultValue: defaultDir, - }) - - if (isCancel(result)) { - cancel('Operation cancelled.') - process.exit(1) - } - - dir = result - } + // In non-interactive mode, we exit early at line 230-233 if no dir provided + const result = await text({ + message: 'Where would you like to create your project?', + placeholder: `./${defaultDir}`, + defaultValue: defaultDir, + }) + + if (isCancel(result)) { + cancel('Operation cancelled.') + process.exit(1) + } + + dir = result }📝 Committable suggestion
🤖 Prompt for AI Agents