Skip to content

ci: let the bundle report app token write PR comments - #2637

Merged
atinux merged 1 commit into
mainfrom
ci/bundle-comment-pr-write
Nov 11, 2026
Merged

atinux merged 1 commit into
mainfrom
ci/bundle-comment-pr-write

Conversation

@atinux

@atinux atinux commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Written by an AI agent on behalf of @atinux.

Since #2618 (6 Nov), PRs haven't gotten bundle-size comments. That PR limited the bundle report app token to issues: write and pull-requests: read. When the bundle-size-comment job tries to post, it gets a 403. Here is #2635 in run 43046127180:

GitHub answered 403 to POST /repos/nuxt/nuxt.com/issues/2635/comments: {"message":"Resource not accessible by integration",...}

Every comment job after #2618 that tried to post failed this way (#2608, #2609, #2611, #2619, #2626, #2631, #2632, #2634, #2635). The last comment from nuxt-com-bundle-report[bot] is on #2613, at 15:11 UTC on 6 Nov. The green runs since then posted nothing. They log "Skipping: no open pull request has the commit of these runs as its head".

What changed

  • bundle-size-comment.yml: the app token now asks for pull-requests: write instead of read. Commenting on a PR through the issues comments endpoint needs this permission. Before ci: report bundle size with the nuxt-bundle-analyzer CLI #2618 the token got every permission the app's installation has, and the same createComment/updateComment calls worked.

Evidence

  • Before: the 403 above, which every post attempt since ci: report bundle size with the nuxt-bundle-analyzer CLI #2618 got.
  • After: not verified yet. bundle-size-comment runs on workflow_run from main, so this PR can't test itself. Once it is merged, rerun the latest bundle-size run of an open PR (for example chore: upgrade comark-content to v0.6.0 #2635). The comment job should then post its comment.
  • The token minting step succeeds today, so the installation grants the permissions this workflow asks for. The old token posted comments fine, which suggests it also has pull-requests: write, but nobody has checked the app settings. If minting fails after merge with a permissions error, add pull-requests: write to the app installation.

ELI5

The bot that posts bundle-size comments was given a key that opens issues but not pull requests, so GitHub stopped it at the door. This gives it the right key.

@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nuxt Ready Ready Preview Nov 11, 2026 3:32pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
Pre-merge checks: Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Description check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@atinux
atinux merged commit 8d1d569 into main Nov 11, 2026
16 checks passed
@atinux
atinux deleted the ci/bundle-comment-pr-write branch November 11, 2026 15:36

This branch was successfully deployed

1 active deployment
Preview — 8b3785e8 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant