Repository navigation
chore(github): release with uppt and npm trusted publishing #7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent stale release PR updates from replacing newer manifest changes.
If two pushes overlap, an older updater can finish last. The pinned action builds the complete
package.jsonfrom its checkout, butsyncReleaseBranchlater uses the current remote base as the parent and force-updates the release branch. This can turn a newer dependency change into a revert in the release PR. (raw.githubusercontent.com)Use an updater that checks the base SHA and recomputes stale plans before writing. Serialise updates for the same base branch as well; the downstream release and publish locks do not protect this job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a
release-prconcurrency group on theprjob in 6864952 so updates run one at a time. Swapping the updater itself is out of scope, uppt is the point of this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 29414
web_search executed:
For GitHub Actions job-level concurrency with cancel-in-progress: false, what are the guarantees about ordering of pending jobs and replacement of pending jobs? Check official GitHub documentation.Length of output: 12017
@benjamincanacThanks. The concurrency group prevents updater jobs from running at the same time. I understand that changing the updater is out of scope.A stale-update risk remains if the base branch advances during a run: uppt can apply an older
package.jsonto the newer base. Before merging a release PR, check itspackage.jsondiff for unintended reversions. Iβm not marking the finding as addressed.You are interacting with an AI system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A push that advances the base during a run queues the next one behind it, and uppt rebases the release branch onto a base that changed a manifest it bumps, so the stale write gets corrected before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 33573
web_search executed:
For GitHub Actions job-level concurrency with cancel-in-progress false and no queue option, what are the guarantees on pending jobs, ordering, replacement and execution? Prefer the official GitHub documentation.Length of output: 9991
Script executed:
Length of output: 17373
@benjamincanacYouβre right that a laterv4update can rebuild the release branch with the newer manifest.There is one limit:
release-prallows only one pending job. A manualv5dispatch can replace a pendingv4update, so the correction is not guaranteed. GitHub documents this queue behaviour.Before merging a release PR, check that an update for the latest
v4push completed and that thepackage.jsondiff has no unintended reversions. Iβm not marking the finding as addressed.You are interacting with an AI system.