Conversation
...tography/Cartography.DynamicMap/Platforms/Android/Clustering/CustomClusterManager.Android.cs
Outdated
Show resolved
Hide resolved
src/Cartography/Cartography.DynamicMap/Platforms/iOS/ClusterView.iOS.cs
Outdated
Show resolved
Hide resolved
src/Cartography/Cartography.DynamicMap/Platforms/iOS/ClusterView.iOS.cs
Outdated
Show resolved
Hide resolved
src/Cartography/Cartography.DynamicMap/Platforms/iOS/MapControl.iOS.cs
Outdated
Show resolved
Hide resolved
src/Cartography/Cartography.DynamicMap/Platforms/iOS/MapControl.iOS.cs
Outdated
Show resolved
Hide resolved
|
changelog should be updated :) |
Fix Map Cluster for feature branch
There was a problem hiding this comment.
Shouldn't this setter be private?
There was a problem hiding this comment.
Shouldn't this be called IsClusteringEnabled? Using "Cluster" suggests that there is only 1 cluster.
There was a problem hiding this comment.
Is this needed? It seems like the xaml associated with this VM wasn't modified?
There was a problem hiding this comment.
Also the same comments from the DynamicMap_FeaturesPageViewModel apply here too.
There was a problem hiding this comment.
I know this comes from a previous PR, but why is the DynamicMap package referencing Google maps on iOS? Shouldn't there be a package specific for GoogleMaps on iOS? GoogleMaps is not the default maps provider on iOS.
There was a problem hiding this comment.
The xml doc on the interface itself should be updated too.
And you could fix the grammar at the same time instead of just adding the period.
There was a problem hiding this comment.
- managed
will handlehandles
There was a problem hiding this comment.
will be manage are managed
There was a problem hiding this comment.
This method (and the one below) should be prefixed by "Get".
Any method should start with a verb.
There was a problem hiding this comment.
Changing to file scoped namespaces changes all the lines of the file, making it almost impossible to spot the changes that are actually related to clustering. I would suggest you undo that change and do it in another PR.
There was a problem hiding this comment.
Where does the -10 value come from?
CHANGELOG.md
Outdated
There was a problem hiding this comment.
I know I'm nit-picky but use some capital letters please. Don't do it if you don't want to.
There was a problem hiding this comment.
Would like some documentation please.
|
Add screenshots and/or gifs of the results from the samples in the PR description. |
3d4e6d3 to
65dfa01
Compare
GitHub Issue: #
Proposed Changes
This is adding Clustering option to Cartography.
Add Clustering to cartography
Checklist
Please check if your PR fulfills the following requirements:
Other information