chore: update readme file, add breaking changes file#56
Open
chore: update readme file, add breaking changes file#56
Conversation
LProulx86
requested review from
MatFillion and
carlh98
and removed request for
MatFillion
Soap-141
reviewed
Oct 10, 2023
Soap-141
previously approved these changes
Oct 10, 2023
carlh98
reviewed
Oct 10, 2023
LProulx86
force-pushed
the
chore/readme
branch
from
3dc18f7 to
2728351
Compare
jeanplevesque
requested changes
Oct 10, 2023
LProulx86
force-pushed
the
chore/readme
branch
2 times, most recently
from
226d209 to
5539eb9
Compare
jeanplevesque
requested changes
Oct 10, 2023
LProulx86
force-pushed
the
chore/readme
branch
4 times, most recently
from
b2e6e20 to
b0d5242
Compare
jeanplevesque
requested changes
Oct 11, 2023
LProulx86
force-pushed
the
chore/readme
branch
3 times, most recently
from
c5f1430 to
d94c224
Compare
jeanplevesque
requested changes
Oct 12, 2023
jeanplevesque
requested changes
Oct 12, 2023
LProulx86
force-pushed
the
chore/readme
branch
4 times, most recently
from
5ff4913 to
06ee23a
Compare
LProulx86
force-pushed
the
chore/readme
branch
from
06ee23a to
dbd73d1
Compare
jeanplevesque
requested changes
Oct 12, 2023
| ### **Samples** | ||
| - Clone project a sample is available. | ||
| - For seeing samples, build and install app with VS on the desire device (Android, IOS, or UWP) | ||
| - For seeing samples, build and install app with VS on the desire device (Android, IOS, or UWP). |
| ### **Samples** | ||
| - Clone project a sample is available. | ||
| - For seeing samples, build and install app with VS on the desire device (Android, IOS, or UWP) | ||
| - For seeing samples, build and install app with VS on the desire device (Android, IOS, or UWP). |
Member
There was a problem hiding this comment.
Checking the samples should not be steps of the Getting Started section.
Please check the following link for the content and structure of the readme: https://dev.azure.com/nventive/Practice%20committees/_wiki/wikis/Committees.wiki/14813/Recipes?anchor=repository-structure-and-documentation
| ### **DynamicMap** | ||
|
|
||
| ### Permission | ||
| - Maps doesn't required to ask permission to the user. |
Member
There was a problem hiding this comment.
Permissions for what? Why are we mentioning this in the Getting Started section if it's not even needed?
It's also a bit confusing because the next nested section is about setting up permissions on Android, which seem to be required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
update readme
What is the current behavior?
What is the new behavior?
Checklist
Please check if your PR fulfills the following requirements:
Other information