feat: add forcedupdate firebase implementation#409
Draft
Marc-Antoine-Soucy wants to merge 4 commits intomainfrom
Draft
feat: add forcedupdate firebase implementation#409Marc-Antoine-Soucy wants to merge 4 commits intomainfrom
Marc-Antoine-Soucy wants to merge 4 commits intomainfrom
Conversation
17 tasks
2d8513e to
bfeed37
Compare
729ac11 to
f91e23b
Compare
f91e23b to
a7dc31f
Compare
b9f6b92 to
2ba7586
Compare
| return services.AddSingleton<IUserProfileRepository, UserProfileRepositoryMock>(); | ||
| } | ||
|
|
||
| private static IServiceCollection AddMinimumVersion(this IServiceCollection services) |
Member
There was a problem hiding this comment.
Don't you need to keep those for the functional tests to work?
Contributor
Author
There was a problem hiding this comment.
The services exist in the view layer, this doesnt have access to the service?
Contributor
Author
There was a problem hiding this comment.
I guess we could try to create some sort of thing that would get the viewservice here, would that be something we really want to do?
Member
There was a problem hiding this comment.
Functional tests don't use anything from the View layer. So I guess this adds to my original question. 😋
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.mdandTemplateConfig.mdif you made changes to templating.AzurePipelines.mdandAPP_README.mdif you made changes to pipelines.Diagnostics.mdif you made changes to diagnostic tools.Architecture.mdand its diagrams if you made architecture decisions or if you introduced new recipes.doc/folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):