Draft
Conversation
jeanplevesque
requested changes
Oct 28, 2025
| x:Name="ChatScrollViewer" | ||
| VerticalScrollBarVisibility="Auto" | ||
| Padding="16"> | ||
| <ItemsControl ItemsSource="{Binding Messages}"> |
Member
There was a problem hiding this comment.
It's probably best to use ListView instead of ItemsControl for a potentially long list of messages due to virtualization.
| @@ -0,0 +1,76 @@ | |||
| using System; | |||
Member
There was a problem hiding this comment.
"Agentic" is not a good feature or domain name because it's an adjective. If what you're building is a Chat, name it "Chat" (or "AI Chat"). Having just the word "Agentic" as the domain name is confusing because it could mean multiple things and it forces us to dig into the content to understand that this is actually a chat bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.mdandTemplateConfig.mdif you made changes to templating.AzurePipelines.mdandAPP_README.mdif you made changes to pipelines.Diagnostics.mdif you made changes to diagnostic tools.Architecture.mdand its diagrams if you made architecture decisions or if you introduced new recipes.doc/folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):