Skip to content

fix: timer callback being executed after timer:stop #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimmyl0l3c wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: timer callback being executed after timer:stop #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bb43d8
fix: 🐛 timer callback being executed after timer:stop
jimmyl0l3c Dec 12, 2025
199c0a4
simplify the callback
jimmyl0l3c Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lua/showkeys/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ M.open = function()
utils.gen_winconfig()
vim.bo[state.buf].ft = "Showkeys"

state.timer = vim.loop.new_timer()
state.timer = vim.uv.new_timer()
state.timer_id = 0

state.on_key = vim.on_key(function(_, char)
if not state.win then
state.win = api.nvim_open_win(state.buf, false, state.config.winopts)
Expand All @@ -25,8 +27,15 @@ M.open = function()

utils.parse_key(char)

state.timer_id = state.timer_id + 1
local current_id = state.timer_id

state.timer:stop()
state.timer:start(state.config.timeout * 1000, 0, vim.schedule_wrap(utils.clear_and_close))
state.timer:start(state.config.timeout * 1000, 0, vim.schedule_wrap(function ()
if state.timer_id ~= current_id then return end
state.timer_id = 0
utils.clear_and_close()
end))
end)

api.nvim_set_hl(0, "SkInactive", { default = true, link = "Visual" })
Expand Down