Skip to content

fix: copyBytes source index wrapping in decode_reader #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobeone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: copyBytes source index wrapping in decode_reader #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions decode_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ func (d *decodeReader) copyBytes(length, offset int) {
d.win[d.w] = d.win[i]
d.w++
i++
if i >= d.size {
i = 0
}
length--
}
}
Expand Down
15 changes: 15 additions & 0 deletions decode_reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package rardecode

import "testing"

func TestCopyBytes_SourceIndexWraps(t *testing.T) {
d := &decodeReader{size: 8, win: make([]byte, 8)}
d.win[6] = 0xAA
d.win[7] = 0xBB
d.w = 4
// offset=6: source starts at (4-6)%8 = 6, wraps past 7 to 0
d.copyBytes(4, 6)
if d.win[4] != 0xAA || d.win[5] != 0xBB {
t.Errorf("first two bytes wrong: got %x %x, want AA BB", d.win[4], d.win[5])
}
}