Remove the Safari/Firefox carve-out from three-finger horizontal swipes - #70
Open
Hariketsu wants to merge 1 commit into
Open
Remove the Safari/Firefox carve-out from three-finger horizontal swipes#70Hariketsu wants to merge 1 commit into
Hariketsu wants to merge 1 commit into
Conversation
gestureTrackpadSwipeThreeFingers dropped Three-Swipe-Left/Right whenever the element under the pointer belonged to Safari or Firefox, preserving a history-navigation gesture both browsers replaced with a two-finger swipe years ago. The check only swallowed configured bindings; vertical swipes were never gated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69.
A bound
three-finger-swipe-leftorthree-finger-swipe-rightnever dispatched with the pointer over a Safari or Firefox window.Cause
gestureTrackpadSwipeThreeFingersgated horizontal dispatch on the application under the pointer, skipping Safari and Firefox. The check dates from Jitouch, when both browsers navigated history with a three-finger swipe; they have used two fingers for years, so the gate only swallowed configured bindings.Fix
Delete the gate in both horizontal branches. Dispatch is now identical in all four directions.
axuiUnderMouse()/nameOfAxui()remain in use elsewhere. A user who wants the old behavior can scope"off"bindings per application, which the configuration model already supports.Checks
./scripts/build.shis clean and./scripts/check.shpasses (25 units).Verified by hand on macOS 15.7.9: with all four directions bound globally, horizontal swipes dispatch with the pointer over Firefox and Safari windows, and vertical swipes are unchanged.