Fix cqhci halt check at the release tag of lf-6.6.36-2.1.0#44
Open
phyin-dj09 wants to merge 10000 commits into
Open
Fix cqhci halt check at the release tag of lf-6.6.36-2.1.0#44phyin-dj09 wants to merge 10000 commits into
phyin-dj09 wants to merge 10000 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect CQHCI_HALT bit check in drivers/mmc/host/cqhci-core.c.
Problem
The linux-imx 6.6.36 branch checks CQHCI_HALT using logical AND:
Since CQHCI_CTL is a bitfield register, the HALT bit must be checked
using bitwise AND.
Impact
The current implementation may incorrectly interpret the CQE state
whenever CQHCI_CTL contains any non-zero value.
On a PHYTEC phyCORE-i.MX8MM based custom board booting from external
eMMC, this resulted in intermittent boot hangs after repeated hard
reboots.
Fix
Replace logical AND with bitwise AND.
Validation