media: csi2-sam: Fix the gasket debug register information#46
Open
MrOneTwo wants to merge 1 commit into
Open
Conversation
The regmap_read uses the base address of the gasket dts node. Those
addresses start at the control registers of its respective gasket, not
at the media block address.
Example from imx8mp.dtsi:
mediamix_gasket0: gasket@32ec0060 {
compatible = "fsl,imx8mp-iomuxc-gpr", "syscon";
reg = <0x32ec0060 0x28>;
};
mediamix_gasket1: gasket@32ec0090 {
compatible = "fsl,imx8mp-iomuxc-gpr", "syscon";
reg = <0x32ec0090 0x28>;
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regmap_read uses the base address of the gasket dts node. Those addresses start at the control registers of its respective gasket, not at the media block address.
Example from imx8mp.dtsi:
mediamix_gasket0: gasket@32ec0060 {
compatible = "fsl,imx8mp-iomuxc-gpr", "syscon";
reg = <0x32ec0060 0x28>;
};
mediamix_gasket1: gasket@32ec0090 {
compatible = "fsl,imx8mp-iomuxc-gpr", "syscon";
reg = <0x32ec0090 0x28>;
};