feat(ssh-agent): Porting identity-policy-based SSH Agent forwarding broker to the Tauri version. - #475
Conversation
The broker merges identities from external agents and stored keys, applies allowlist or allow-all policies, and routes signing requests to the owning provider. Raw relay remains for single-provider topologies to preserve unknown extensions.
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 488aa6bc5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Stable: No (tracking issue: #3347) | ||
| # Wrap comments to fit the line width | ||
| # Default value: false | ||
| wrap_comments = true |
There was a problem hiding this comment.
With the repository's stable Rust toolchain, this option and the other active settings marked Stable: No are ignored; notably, ignore = ["target", "vendor"] is ignored as well. Running the required cargo fmt --all -- --check now exits nonzero, emits unstable-option warnings, and reports formatting diffs across both vendor/ and project crates, so the standard formatting check cannot pass unless the configuration uses stable options or the repository explicitly pins nightly rustfmt.
AGENTS.md reference: AGENTS.md:L210-L217
Useful? React with 👍 / 👎.
2 participants
背景
本 PR 将 Tauri 版本中已有的 SSH Agent 认证与可配置转发能力移植到 GPUI 版本，保持既有用户行为、数据兼容性和安全策略，不引入一套全新的 Agent 协议设计。
主要对齐 Tauri 提交：
05884e1b：SSH Agent 认证与基础转发a4792c02：可配置 Agent 转发、身份策略与 broker主要变更
nyaterm-core。agent_endpoint/agent_forwarding字段迁移逻辑。GPUI 适配
nyaterm-core：持久化模型、迁移和结构校验。nyaterm-transport：Agent broker、SSH channel wiring 和签名处理。nyaterm-desktop：连接编辑器、预览 UI、session 配置构建。nyaterm-store：保存密钥 revision、备份/同步兼容。rustfmt.toml：建立 Rust 2024 项目的统一格式化基线，并忽略target与vendor。兼容性与安全
vendor/内容。验证
cargo check --workspace通过。nyaterm-core测试通过。nyaterm-store测试通过。git diff --check通过。补充：
488aa6b的rustfmt.toml与功能移植相对独立；添加了一些格式化规则，看看是否可以合并