Repository navigation
Use a fast-forward icon for background flows - #7132
Open
rowanseymour wants to merge 1 commit into
Open
rowanseymour wants to merge 1 commit into
rowanseymour wants to merge 1 commit into
Conversation
Background flows run start to finish without waiting on the contact, which the layers icon didn't convey.
|
Review summary The change is correct. I found no correctness, security or performance problems. Minor points:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background flows can't wait for a contact's reply, so they run from start to finish in one go without interrupting other flows. The old layers icon didn't say anything about that. A fast-forward icon shows a flow that runs straight through.
Changes
components/src/Icons.ts:flow_backgroundnow maps to the figma pack'sfast-forwardinstead oflayers-two-01.components/static/svg/index.svg: regenerated sprite. It addsfast-forwardand dropslayers-two-01, which nothing else used.Test plan
bun run test:fastin the components devcontainer. One screenshot test failed on a hover tooltip intemba-contact-detailsand passed on rerun; it doesn't involve this icon.Screenshots