Repository navigation
Retain actual admission scheduling observations in tick receipts - #60
Merged
Merged
Conversation
Exercise real ticks for capacity, priority and declared-refill observations. Preserve zero, unread and absent cases distinctly in both durable receipt surfaces.
Persist the final capacity, priority and refill-stop observations in both last_tick and svrf.tick/1 when the original summary contains them. Keep unread observations distinct from zero or absence. This adds no reads or scheduling decisions. The six regression cases were committed and run before this change. The unchanged full Python command now passes all 461 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A tick already observes admission capacity, priority-command results, and a refill-stop reason. These values disappear from both the saved
last_tickandsvrf.tick/1receipt. An operator inspecting the completed tick therefore cannot distinguish an observed zero from an unread capacity, determine which priority read was used, or receive the declared-read barrier that stopped refill.Change
Copy
admission_capacity,admission_priority, andrefill_stoppedfrom the actual final tick summary into both existing persistence surfaces when the fields are present. Unobserved dictionaries keep their exact reasons; fields that were never observed remain absent. These are the last values retained in the summary, not an invented sequence of intermediate refill reads. No additional command, scheduling decision, gate, or schema-version change is introduced.Validation
Test-only commit
14132043ee17b9c0688568fdd15e230c0a6c733dwas pushed first. Against unchanged runtime, the six new real-tick regression cases produced five failing cases (14 missing-field subtest failures) and one passing absence control. They cover capacity plus priority, zero capacity, unread capacity, unread priority, the declared-read refill barrier, and unconfigured fields.Production-only commit
9473c152550d029668010915b2f563190bcd1134, tree85fe3281a921c39bb9d66a3face2019663eca0e0, passes the originalmake test: all 461 tests in 22.414 seconds. All 180 tracked files match their exact before/after identities; every original test and fake is preserved. Full raw test-log SHA256:5a0bf47189c154e43e41d0793e47b8d8b55246b1479acca928aa2d803a18605c.An independent source and execution review verified that only
saveand_write_tick_receiptchanged and all 38 other daemon function ASTs remain exact. Original proof and container CI remain required;lakeanddockerare unavailable locally. Actual deployed observations remain unobserved until the existing deployment owner installs a qualified release.This is the single continuation on the existing owner branch after #59 merged.