Keba: Fix type mismatch warning on setState for phaseCount#706
Open
Keba: Fix type mismatch warning on setState for phaseCount#706
Conversation
Contributor
|
Hmm... Just reading it I don't think that'll fix the issue... I mean, yes, it will get rid of the warning because a invalid QVariant will be converted to 0 on a toUint() but I suppose the actual issue in a different place, perhaps even the core or the app, in that it feeds the API with a invalid QVariant in the first place... Can we reproduce it somehow? |
mzanetti
approved these changes
Aug 18, 2023
mzanetti
added
landing
experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nymea-plugins pull request checklist:
Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"
Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.
Did you update the plugin's README.md accordingly?
Did you update translations (
cd builddir && make lupdate)?