Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| #include "engine.h" | ||
| #include "loggingcategories.h" | ||
| #include "../version.h" | ||
| #include "version.h" |
There was a problem hiding this comment.
The new CMake build puts version.h into the binary directory and adds that directory to the include path, so switching the source files to #include "version.h" works for CMake. However the repository still ships qmake projects for Qt5/Qt6, and those project files were not updated to add the top-level build directory to INCLUDEPATH. With the relative include removed, qmake builds now fail because the compiler cannot locate version.h when compiling libnymea-remoteproxy (and the other binaries changed in this commit). Please either keep the relative include (../version.h) or extend the qmake files to expose the generated header on the include path.
Useful? React with 👍 / 👎.
1 participant
No description provided.