Add queued media workflows and configurable video derivatives - #79
Open
arifje wants to merge 16 commits into
Open
Add queued media workflows and configurable video derivatives#79arifje wants to merge 16 commits into
arifje wants to merge 16 commits into
Conversation
arifje
marked this pull request as ready for review
August 30, 2026 19:43
Contributor
|
Wow, this is quite a large and comprehensive PR, well-done. I'll need a bit to digest/test this, and also it'll need to be ported to Craft 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
This brings the downstream media workflow improvements onto a clean upstream v4 base:
Refresh and output-path behavior
The new
refreshVideoAsset()workflow remains explicit. It does not install a global Asset replacement listener and does not depend onqueueVideosOnAssetUpload.Refresh cleanup and the follow-up
EncodeVideojob derive the same exact output path, including:The refresh job reports the Asset ID, removed file count, and follow-up job ID in Craft’s logs. Cleanup or queue-push failures leave a failed job instead of reporting a misleading successful refresh.
Generated media URLs use the regenerated file’s modification time for safe cache busting.
Compatibility
develop-v4.useHashedNames.videoEncodeMaxRetriesto0for manual-only retries.bufsize.Production validation
I have been running and testing these features on a production Craft project for several weeks without encountering any issues.
Verification
versionwarning only)git diff --checkThe focused regression harness covers upload queueing disabled plus explicit refresh, exact subfolder and filename parity, existing derivative removal, follow-up encoding, poster path behavior, video/GIF/audio queue jobs, retry handling, and versioned output URLs.