fix syn dependency features - #3
Open
markbt wants to merge 1 commit into
Open
Conversation
`quickcheck_async` uses items from `syn` that are only available if the `full` feature is enabled, however it doesn't specify that in its dependency. Often that isn't a problem, as many other things depend on `syn` and include that feature, and Cargo's feature unification means `full` gets enabled anyway. You can reproduce this by removing all the dev-dependencies and running `cargo check`. Add the feature to the syn dependency explicitly so it's always provided.
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jul 30, 2025
Summary: Upstream quickcheck_async depends on `syn` but doesn't include the correct features. In some circumstances that means compilation fails with errors like: ``` error[E0432]: unresolved imports `syn::FnArg`, `syn::ItemFn`, `syn::Pat` note: the item is gated behind the `full` feature ``` Upstream PR nytopop/quickcheck_async#3 fixes this. Vendor that fix. Reviewed By: dtolnay Differential Revision: D79173248 fbshipit-source-id: e5dfad1a1db497622ae3a5544589edda8dc5055a
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jul 30, 2025
Summary: Upstream quickcheck_async depends on `syn` but doesn't include the correct features. In some circumstances that means compilation fails with errors like: ``` error[E0432]: unresolved imports `syn::FnArg`, `syn::ItemFn`, `syn::Pat` note: the item is gated behind the `full` feature ``` Upstream PR nytopop/quickcheck_async#3 fixes this. Vendor that fix. Reviewed By: dtolnay Differential Revision: D79173248 fbshipit-source-id: e5dfad1a1db497622ae3a5544589edda8dc5055a
|
@nytopop Ping |
|
@nytopop This is a quick fix. Can you release this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quickcheck_asyncuses items fromsynthat are only available if thefullfeature is enabled, however it doesn't specify that in its dependency.Often that isn't a problem, as many other things depend on
synand include that feature, and Cargo's feature unification meansfullgets enabled anyway. You can reproduce this by removing all the dev-dependencies and runningcargo check.This PR adds the feature to the syn dependency explicitly so it's always provided.