Skip to content

suggestions for additional improvements - #125

Open
duccas wants to merge 3 commits into
o1-labs:mainfrom
Staketab:staketab-fix
Open

suggestions for additional improvements#125
duccas wants to merge 3 commits into
o1-labs:mainfrom
Staketab:staketab-fix

Conversation

@duccas

@duccas duccas commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@dkijania

Copy link
Copy Markdown
Contributor

hey @duccas this is looking good. can you rebase?

@SanabriaRusso

Copy link
Copy Markdown
Collaborator

Thanks for these @duccas — the dev-setup cleanups are appreciated, and none of this touches the GraphQL API surface (schema/resolvers/CORS), so no server-side compatibility concerns. One heads-up: the branch has drifted behind main since October, and #158 ("refresh stale Mina references — point to mainnet 3.3.1", 28e0cf8) has since landed and overlaps two of the three files here:

  • .env.example.composemain is already on minaprotocol/mina-daemon:3.3.1-7b34378-bullseye-mainnet with the mainnet PEER_LIST_URL. This PR would roll that back to 3.2.0-…-focal, so this file is best dropped (it's the source of the current conflict).
  • scripts/generate_libp2p.shchore: refresh stale Mina references — point to mainnet 3.3.1 #158 already reworked this to generate both keypairs from the mina-daemon image (docker-only, no local mina binary needed), which covers the retired-mina-generate-keypair fix this PR was after.

The piece still worth landing is the download_db.sh change: main still hardcodes docker-compose stop postgres (Compose v1, EOL since 2023), while our own docs/getting-started.md tells users to run docker compose up (v2) — so on a v2-only host the docs work but this script fails with "command not found". Your get_docker_compose_cmd() detection fixes exactly that.

Suggestion: rather than rebasing the whole branch, would you be up for a small fresh PR with just the download_db.sh detection hunk? That lands the real improvement cleanly and we can close this one out. Happy to help either way.

@dkijania

Copy link
Copy Markdown
Contributor

Thanks again @duccas for these — following up on @SanabriaRusso's review.

The download_db.sh Compose-v2 detection was the real fix here, and I've landed it on a clean branch off main in #202, crediting this PR as its source. The other two files have since been overtaken on main:

So with the download_db.sh improvement now carried forward in #202, I'd suggest closing this one out to clear the conflict. Really appreciate the dev-setup cleanups — the Compose-v2 detection in particular fixes a real break for anyone on a v2-only host following our own docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants