Skip to content

EmotionFX: Ability for SimpleMotionComponent & AnimGraphComponent to exist on same entity#19192

Merged
nick-l-o3de merged 2 commits intoo3de:developmentfrom
rossbridger:emfx_simple_motion_and_animgraph_coexistence
Aug 16, 2025
Merged

EmotionFX: Ability for SimpleMotionComponent & AnimGraphComponent to exist on same entity#19192
nick-l-o3de merged 2 commits intoo3de:developmentfrom
rossbridger:emfx_simple_motion_and_animgraph_coexistence

Conversation

@rossbridger
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is a revival of aws/lumberyard#540, I revived it so that I can play an animation clip on the editor without having to disable or enable the simple motion component.

How was this PR tested?

Manually tested

@rossbridger rossbridger requested review from a team as code owners August 13, 2025 14:01
@rossbridger rossbridger force-pushed the emfx_simple_motion_and_animgraph_coexistence branch from f176efc to 24af643 Compare August 13, 2025 14:04
…exist on same entity

Signed-off-by: Ross Charles C. <10781734+rossbridger@users.noreply.github.com>
@nick-l-o3de
Copy link
Copy Markdown
Contributor

nick-l-o3de commented Aug 15, 2025

Looks like a test may need to be updated - maybe the test is no longer valid?

[2025-08-14T16:54:15.809Z] [----------] 1 test from CanAddSimpleMotionComponentFixture
[2025-08-14T16:54:15.809Z] [ RUN      ] CanAddSimpleMotionComponentFixture.CanAddSimpleMotionComponent
[2025-08-14T16:54:15.809Z] /data/workspace/o3de/Gems/EMotionFX/Code/Tests/Integration/CanAddSimpleMotionComponent.cpp:85: Failure
[2025-08-14T16:54:15.809Z] Value of: isActive
[2025-08-14T16:54:15.809Z]   Actual: true
[2025-08-14T16:54:15.809Z] Expected: false
[2025-08-14T16:54:15.809Z] 
[2025-08-14T16:54:15.809Z] [  FAILED  ] CanAddSimpleMotionComponentFixture.CanAddSimpleMotionComponent (331 ms)
[2025-08-14T16:54:15.809Z] [----------] 1 test from CanAddSimpleMotionComponentFixture (331 ms total)

Please fix the test

  1. set your "startup project" in visual studio, to the test module that this code is in.
  2. hit the run button. (optionally, add --gtest_break_on_failure --gtest_filter=*CanAddSimpleMotion* to the debug options)

Signed-off-by: Ross Charles C. <10781734+rossbridger@users.noreply.github.com>
@rossbridger rossbridger force-pushed the emfx_simple_motion_and_animgraph_coexistence branch from 24af643 to f074043 Compare August 15, 2025 17:04
Copy link
Copy Markdown
Contributor

@nick-l-o3de nick-l-o3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a terribly weird test!
The test was named CanAddSimpleMotionComponent and previously made sure the added component was not able to be active.

@nick-l-o3de nick-l-o3de merged commit 676860e into o3de:development Aug 16, 2025
6 of 10 checks passed
@rossbridger rossbridger deleted the emfx_simple_motion_and_animgraph_coexistence branch August 17, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants