Adding support for specifying a Proxy to use for the connection#38
Open
davydotcom wants to merge 1 commit into
Open
Adding support for specifying a Proxy to use for the connection#38davydotcom wants to merge 1 commit into
davydotcom wants to merge 1 commit into
Conversation
Signed-off-by: David Estes <davydotcom@gmail.com>
peter-boden
requested changes
Jun 1, 2026
| SSLContext sslcontext = SSLContext.getInstance("TLS"); | ||
| sslcontext.init(null, new TrustManager[]{noCaTrustManager}, null); | ||
| sslsf = new SSLConnectionSocketFactory(sslcontext, NoopHostnameVerifier.INSTANCE); | ||
| sslsf = new SSLConnectionSocketFactory(sslcontext, NoopHostnameVerifier.INSTANCE) { |
Member
There was a problem hiding this comment.
Why no socks handling for secure ssl, i.e. ssl with a valid certificate?
Also, this seems like duplicate code?
Why not do something like:
static class ProxyConnectionSocketFactory implements ConnectionSocketFactory {
private final ConnectionSocketFactory delegate;
private final ProxyInfo proxyInfo;
ProxyConnectionSocketFactory(ConnectionSocketFactory delegate, ProxyInfo proxyInfo) {
this.delegate = delegate;
this.proxyInfo = proxyInfo;
}
/**
* Wraps the given factory with SOCKS proxy support if needed.
* Returns the original factory unchanged if proxy is null or not SOCKS.
*/
static ConnectionSocketFactory wrapIfNeeded(ConnectionSocketFactory factory, ProxyInfo proxyInfo) {
if (proxyInfo != null
&& proxyInfo.getProxyType() == ProxyInfo.ProxyType.SOCKS
&& proxyInfo.getHost() != null
&& proxyInfo.getProxyPort() != null) {
return new ProxyConnectionSocketFactory(factory, proxyInfo);
}
return factory;
}
// ... delegate methods ...
} Use it like this:
private Registry createConnectionSocketFactoryRegistry() {
ConnectionSocketFactory plainsf = PlainConnectionSocketFactory.getSocketFactory();
ConnectionSocketFactory sslsf = createSslSocketFactory();
return RegistryBuilder.<ConnectionSocketFactory>create()
.register(HTTP_PROTOCOL, ProxyConnectionSocketFactory.wrapIfNeeded(plainsf, proxyInfo))
.register(HTTPS_PROTOCOL, ProxyConnectionSocketFactory.wrapIfNeeded(sslsf, proxyInfo))
.build();
} | package org.ovirt.engine.sdk4; | ||
|
|
||
| public class ProxyInfo { | ||
| protected String host; |
Member
There was a problem hiding this comment.
why are some fields protected?
| protected String user; | ||
| protected String password; | ||
| private String proxyDomain; | ||
| private String proxyWorkstation; |
Member
There was a problem hiding this comment.
proxyWorkstation isn't set in the constructor? Any reason for that?
| } | ||
|
|
||
|
|
||
| //create an enum for proxy type |
| protected String user; | ||
| protected String password; | ||
| protected String token; | ||
|
|
| private String ssoTokenName = null; | ||
| private String ssoUrl = null; | ||
| private String ssoRevokeUrl = null; | ||
|
|
| if(proxyInfo.getHost() != null && proxyInfo.getProxyPort() != null) { | ||
| clientBuilder.setProxy(new HttpHost(proxyInfo.getHost(), proxyInfo.getProxyPort())); | ||
| if(proxyInfo.getUser() != null) { //authenticated proxy | ||
| NTCredentials ntCreds = new NTCredentials(proxyInfo.getUser(), proxyInfo.getPassword(), proxyInfo.getProxyWorkstation(), proxyInfo.getProxyDomain()); |
Member
There was a problem hiding this comment.
NTCredentials feels oddly specific? I would say the majority of proxies doesn't use windows domain auth?
| private ProxyType proxyType; | ||
|
|
||
|
|
||
| public ProxyInfo(String host, Integer proxyPort, String user, String password, String proxyDomain, ProxyType proxyType) { |
Member
There was a problem hiding this comment.
I would add some validation to the constructor to check for mandatory fields, this would make it more user friendly.
| clientBuilder.setProxyAuthenticationStrategy(new ProxyAuthenticationStrategy()); | ||
| } | ||
| } | ||
| } else if(proxyInfo.getProxyType() == ProxyInfo.ProxyType.SOCKS) { |
Member
There was a problem hiding this comment.
Just remove this if, just having this branch for that comment is kind of useless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library does not allow you to specify a Proxy for the connection. This adds support for passing Proxy Information for both SOCKS or HTTP proxies