Skip to content

Make FormDataEntryValue type safe by checking of type string#577

Draft
orangemug wants to merge 1 commit into
mainfrom
fix/make-formdataentryvalue-typesafe
Draft

Make FormDataEntryValue type safe by checking of type string#577
orangemug wants to merge 1 commit into
mainfrom
fix/make-formdataentryvalue-typesafe

Conversation

@orangemug
Copy link
Copy Markdown
Contributor

@orangemug orangemug commented Feb 3, 2026

How to review this PR

Leave this text block for the reviewer

  • Check component hierarchy is followed correctly
  • Check the design Heuristics have been followed
  • Check naming conventions have been applied
  • Check for these gotchyas:
    • Missing exports for Oak components
    • Accidental export of Internal components
    • Snapshots of unexpected components have been modified
    • Circular dependencies
    • Code duplication (via not using base components)
    • Non-functional storybook for this or related components
    • Sensitve files changed eg. atoms, or style tokens
    • Relative imports
    • Default exports

Add your PR description below

Make FormDataEntryValue type safe by checking of type string

Note that FormDataEntryValue can be either string or File, see https://bun.com/reference/bun/FormDataEntryValue

Fixes

Link to the design doc

None

A link to the component in the deployment preview

https://oak-components-storybook-git-fix-make-formdataentryvalue-504ff4.vercel.thenational.academy/

Testing instructions

ACs

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oak-components-storybook Ready Ready Preview, Comment Feb 3, 2026 4:31pm

Request Review

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant