fix: make Application listen promise resolve after aborted

application.test.ts

@@ -1105,10 +1105,8 @@ Deno.test({
 });
 
 Deno.test({
-  name: "Application.listen() - no options",
+  name: "Application.listen() - no options - aborted before onListen",
   // ignore: isNode(),
-  ignore: true, // there is a challenge with serve and the abort controller that
-  // needs to be isolated
   async fn() {
     const controller = new AbortController();
     const app = new Application();
@@ -1118,7 +1116,45 @@ Deno.test({
     const { signal } = controller;
     const p = app.listen({ signal });
     controller.abort();
-    await p;
+    await assertRejects(
+      async () => await p,
+      "aborted prematurely before 'listen' event",
+    );
+    teardown();
+  },
+});
+
+Deno.test({
+  name: "Application.listen() - no options - aborted after onListen",
+  async fn() {
+    const controller = new AbortController();
+    const app = new Application();
+    app.use((ctx) => {
+      ctx.response.body = "hello world";
+    });
+    const { signal } = controller;
+    const p = app.listen({ signal });
+    app.addEventListener("listen", () => controller.abort());
+    const GRACEFUL_TIME = 1000;
+    let timer: number | undefined;
+    const raceResult = await Promise.race([
+      new Promise((resolve) => {
+        p.then(() => {
+          clearTimeout(timer);
+          resolve("resolved cleanly");
+        });
+      }),
+      new Promise((resolve) =>
+        timer = setTimeout(
+          () => resolve("likely forever pending"),
+          GRACEFUL_TIME,
+        )
+      ),
+    ]);
+    assert(
+      raceResult === "resolved cleanly",
+      `'listen promise' should resolve before ${GRACEFUL_TIME} ms`,
+    );
     teardown();
   },
 });

http_server_native.ts

@@ -79,6 +79,12 @@ export class Server<AS extends State = Record<string, any>>
     const { signal } = this.#options;
     const { onListen, ...options } = this.#options;
     const { promise, resolve } = createPromiseWithResolvers<Listener>();
+    if (signal?.aborted) {
+      // if user somehow aborted before `listen` is invoked, we throw
+      return Promise.reject(
+        new Error("aborted prematurely before 'listen' event"),
+      );
+    }
     this.#stream = new ReadableStream<NativeRequest>({
       start: (controller) => {
         this.#httpServer = serve?.({
@@ -96,6 +102,11 @@ export class Server<AS extends State = Record<string, any>>
           signal,
           ...options,
         });
+        // closing stream, so that the Application listen promise can resolve itself
+        // https://developer.mozilla.org/en-US/docs/Web/API/ReadableStreamDefaultController/close
+        signal?.addEventListener("abort", () => controller.close(), {
+          once: true,
+        });
       },
     });