Fix: duck visible through alpha-transparent card videos - #6
Merged
Merged
Conversation
The Pollen clips are alpha-transparent WebMs (moves-portrait-alpha/*), so once cards started streaming them the transparent regions composited over the always-present DuckMark, rendering the mascot through the video. The fallback now crossfades out as the media layer fades in (240ms, reduced-motion aware); it stays fully visible whenever no media is paintable, so slow networks still see the mascot instead of an empty frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On cards playing the Pollen clips (e.g. alpha-walking), the static DuckMark remained visible through the video: the clips under
moves-portrait-alpha/*are alpha-transparent WebMs, so their transparent regions composited over the always-present duck fallback layer. Cards never showed this before because they previously played local opaque MP4 loops.Fix
Complete the layering design with a crossfade:
onLoad/canplay, hydration-race-proof via the existing ref sync), the duck fallback fades out in the same 240ms;The halftone dots of the card container remain the composite background for the transparent clips, consistent with the site motif.
Test plan
pnpm test(17/17),pnpm build<video>, 18 duck layers, 7 poster layers