Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/stale-unguarded-exemption.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
---

Empty the `KNOWN_UNGUARDED` exemption map. #570 and #571 were each green on
their own branch; #571 carved `crm_opportunity_line_item.unit_price_positive`
out as a documented exemption while #570 landed that very guard in parallel, so
the entry went stale the moment both merged and #571's own staleness check
turned `main` red. Removing the entry is the fix the check was written to force.
Tooling only — releases nothing.
16 changes: 8 additions & 8 deletions test/object-validation-predicates.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ function unguardedFields(source: string): string[] {
/**
* Rules still shipping an unguarded comparison, with the reason.
*
* This is a shrinking list, not a permanent exemption: the entry below is the
* remaining half of #514 item 3, carved into its own change because it touches
* a different object family. The "no stale entries" test keeps this honest —
* once that rule grows its guard, this map must be emptied or CI fails.
* Empty, and the "no stale entries" test below keeps it that way. It held one
* entry — `crm_opportunity_line_item.unit_price_positive`, the half of #514
* item 3 that was carved out of #571 because it touches a different object
* family. #570 landed that guard in parallel, so the exemption went stale the
* moment both merged and this file's own staleness check turned main red. That
* is the mechanism working: an exemption may outlive its fix by exactly one
* merge, never longer.
*/
const KNOWN_UNGUARDED: Record<string, string> = {
'crm_opportunity_line_item.unit_price_positive':
'#514 item 3, opportunity_line_item half — tracked separately',
};
const KNOWN_UNGUARDED: Record<string, string> = {};

describe('validation predicates are null-guarded', () => {
it('finds script validations to check at all', () => {
Expand Down
Loading