fix(ux): P1 — i18n the Apps, Notifications, More & AI Assistant screens - #105
Merged
Conversation
These screens shipped hardcoded English, so a Chinese (or Arabic) user saw a
mix of localized chrome and English body text. Wire every user-facing string
(titles, empty states, section headers, menu labels, the assistant's header /
empty state / example prompts / input / actions, plus a11y labels) through
i18next with new `apps`/`notifications`/`more`/`ai` namespaces in en, zh and
ar. Apps uses an i18next plural for the installed-count.
Home is intentionally left to its own PR (already i18n'd there) to avoid a
merge conflict.
The AIAssistant test now resolves `t(key)` against the real en bundle, so its
English assertions hold while the screen reads from i18n.
Verified in the browser (zh): Apps ("已安装 1 个应用"), Notifications, More,
and the AI Assistant empty state all render Chinese. 1266 tests pass, lint clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # locales/ar.json # locales/en.json # locales/zh.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 from the mobile UX walkthrough: several screens shipped hardcoded English, so a zh/ar user saw localized navigation chrome wrapped around English body text.
What's localized
Every user-facing string (and a11y label) on:
New
apps/notifications/more/ainamespaces added to en / zh / ar.Notes
AIAssistanttest now resolvest(key)against the realen.jsonbundle (a smallreact-i18nextmock), so its English assertions still hold while the screen reads from i18n.Verification
Browser (zh locale): Apps shows
已安装 1 个应用, Notifications暂无通知 / 你已全部处理完毕…, More账户 / 账户与安全 / AI 助手 / 退出登录, and the AI Assistant empty state向助手提问+ Chinese example prompts. 1266 tests pass, typecheck + lint clean.🤖 Generated with Claude Code