fix(i18n): localize the remaining hardcoded screen headers - #115
Merged
Conversation
Found on the iPhone 17 simulator: the Language screen showed a hardcoded English "Language" header while the rest of the app was Chinese. The same gap existed on the Account, Packages, and Flow-detail screens. Route their ScreenHeader titles through i18next (reusing `common.language`, `more.sectionAccount`, `more.flows`; new `common.packages` in en/zh/ar). Verified on device: the Language header now reads "语言". 1298 tests pass, typecheck + lint clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on the iPhone 17 simulator: the Language screen rendered a hardcoded English "Language" header while the rest of the app was Chinese. The same gap existed on Account, Packages, and Flow-detail.
Route those
ScreenHeadertitles through i18next:language.tsx→common.languageaccount.tsx→more.sectionAccountflows/[name]→more.flowspackages.tsx→ newcommon.packages(en/zh/ar)Verified on device: the Language header now reads "语言". 1298 tests pass, typecheck + lint clean.
🤖 Generated with Claude Code