feat(ux): clearer list sort chips + a group-by control - #118
Merged
Conversation
Sort chips only hinted their state on the active chip (a tiny chevron) and
the active colour was hardcoded #1e40af, washing out in dark mode. Now every
sortable chip carries an up/down affordance so it reads as sortable, the
active chip shows a real directional arrow, and both adapt to the theme
(accent = #60a5fa dark / #1e40af light).
Add a Group control: a chip that opens a sheet to group the list by any
column (or none). It overrides the view's configured grouping for the
session; `buildListItems` gained an optional override arg (a field name to
group by, null to force flat, undefined to defer to the view) — covered by
two new unit tests.
While here, wire the renderer's remaining hardcoded strings (search
placeholder, empty + load-error states, retry) through i18n, and add
records.{loadError,sortBy,groupBy,groupNone} in en/zh/ar.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX-C — List sort clarity + group-by
Third of the UX improvements from the browser walkthrough.
Sort chips
#1e40af— nearly invisible on a dark chip.⇅affordance, the active chip shows a real directional arrow (↑/↓), and the accent is theme-aware (#60a5fadark /#1e40aflight).Group-by
buildListItemsgained an optional override arg: a field name to group by,nullto force a flat list,undefinedto defer to the view'sgrouping. Two new unit tests cover override + force-flat.i18n
Wired the renderer's remaining hardcoded strings (search placeholder, empty + load-error states, retry) through i18n, and added
records.{loadError,sortBy,groupBy,groupNone}in en/zh/ar.Verified
Browser (375dp, dark, zh): tapped Status sort → blue outline +
↑; opened 分组 → grouped Tasks into COMPLETED (2) / IN_PROGRESS (1) / NOT_STARTED (4) with the chip showing "Status". Full suite: 1300 passing.🤖 Generated with Claude Code