feat(ux): inline-edit select/status fields from the record detail - #124
Merged
Conversation
The final walkthrough item. A select/status/priority field on the detail
screen now renders its coloured badge with a pencil affordance; tapping opens
an option picker, and choosing a value persists it (data.update) and refetches,
with a saving spinner and a success/failure toast. Non-select fields stay
read-only, and a field marked readonly is left alone.
DetailViewRenderer gained an optional `onFieldEdit(field, value)` prop (the
detail screen wires it); when absent the detail is strictly read-only as before.
i18n: records.{updated,updateFailed,editField} in en/zh/ar.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX-F — Inline status edit (final walkthrough item)
The last remaining item from the UX walkthrough.
What
data.update) and refetches, with a saving spinner and a success/failure toast.readonlyis left alone.How
DetailViewRenderergained an optionalonFieldEdit(field, value)prop — the detail screen wires it to adata.update+ refetch + toast. When the prop is absent the detail is strictly read-only, exactly as before (so other callers are unaffected). i18n:records.{updated,updateFailed,editField}in en/zh/ar.Verified
Browser (375dp, dark): tapped Status on a task → picker (Not Started / In Progress / Waiting / Completed ✓ / Deferred) → chose In Progress → badge updated Completed → In Progress with the change persisted. Full suite: 1328 passing, tsc + lint clean.
This closes the UX optimization pass (dark mode, dashboard KPI grid + measure/derived values, list sort/group/density/value-labels, detail action overflow + dark-mode fix, form sticky-save + unsaved guard, home recents + quick-create, notification grouping, recent searches, haptics, inline status edit).
🤖 Generated with Claude Code