test(ux): render + interaction coverage for new UX components - #126
Merged
Conversation
Cover the three components added in the UX pass that had only store/helper unit tests: - DensitySelector — renders both options; pressing one writes the global density through ui-store; toggles back. - QuickCreateSheet — flattens object leaves from app navigation (incl. nested groups), dedupes an object surfaced under multiple views, ignores non-object leaves; pressing a row routes to the object's create form and closes the sheet; empty hint when nothing is creatable. - EditableSelectField (via DetailViewRenderer) — stays read-only without an onFieldEdit handler; opening the picker and choosing a new option calls onFieldEdit(field, value); re-selecting the current value is a no-op. QuickCreateSheet's chain doesn't transitively import ~/lib/i18n, so the test imports it to initialize i18next. Full suite 1337 passing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component test coverage
The UX pass added three components that only had store/helper unit tests. This adds render + interaction coverage.
DensitySelector
ui-store; toggles back.QuickCreateSheet
/(app)/<app>/<object>/newand closes the sheet.EditableSelectField (via
DetailViewRenderer)onFieldEdithandler.onFieldEdit(field, value).Note
QuickCreateSheet's import chain doesn't transitively pull in~/lib/i18n, so the test imports it to initialize i18next (otherwiset()returns raw keys). Full suite: 1337 passing.🤖 Generated with Claude Code