Skip to content

docs(adr): ADR-0091 accepted — grant lifecycle decisions confirmed; D3 gains the no-self-renewal rule - #2764

Merged
os-zhuang merged 1 commit into
mainfrom
claude/adr-0091-accept
Jul 10, 2026
Merged

docs(adr): ADR-0091 accepted — grant lifecycle decisions confirmed; D3 gains the no-self-renewal rule#2764
os-zhuang merged 1 commit into
mainfrom
claude/adr-0091-accept

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Summary

Review outcome for ADR-0091 (#2751): Status → Accepted (decider recorded). All seven decisions confirmed as proposed:

  • D3 delegation keeps substitution (union) semantics with the 30-day configurable ceiling;
  • D4 break-glass stays unapproved with the 4h default window (pre-authorization list + loud alert + D5 review as the compensating controls);
  • D1 scope stays confined to the two user-grant tables; D2 resolution-time filtering is the sole correctness mechanism.

One addition from review: D3 rule 4 now cuts chains two ways — a delegated row is not re-delegatable and not self-renewable. The delegate cannot extend valid_until; continuing past expiry requires a NEW delegation by the delegator (or an admin), leaving a fresh audit record. A "temporary" grant that can be quietly rolled forever is a permanent grant with extra steps.

Implementation (L1: spec columns + resolver filtering + tests) starts after this merges, targeting 13.1.

Verification

Docs-only (one ADR file). No code, no changeset.

🤖 Generated with Claude Code

https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H


Generated by Claude Code

…3 gains the no-self-renewal rule

Review outcome: delegation keeps substitution (union) semantics with the
30-day configurable ceiling; break-glass stays unapproved with the 4h
window (pre-authorization list + alert + D5 review as compensating
controls); D1 scope stays confined to the two user-grant tables; D2
resolution-time filtering confirmed as the sole correctness mechanism.
Added per review: a delegated row is not self-renewable — extension
requires a NEW delegation by the delegator, with its own audit record.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Jul 10, 2026 9:40am

Request Review

@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation and removed size/s labels Jul 10, 2026
@os-zhuang
os-zhuang marked this pull request as ready for review July 10, 2026 09:48
@os-zhuang
os-zhuang merged commit b367cc8 into main Jul 10, 2026
15 checks passed
@os-zhuang
os-zhuang deleted the claude/adr-0091-accept branch July 10, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants