chore: bump objectui to a136322f8723 — the console must carry the ADR-0110 D1 fix before v17 ships - #3982
Merged
Conversation
…-0110 D1 fix The pin was at 4a4829d0ef39, which predates objectui#2970 (the D1 client fix). build-console.sh builds the shipped SPA at the PINNED sha, so v17 would have gone out with a console that still posts action.target to /actions/:object/:action. A v17 server resolves the declaration by name and refuses an unresolvable one (ADR-0110 D3), so every target-bound script action would 404 from the shipped console — a hard regression on a path that worked (ungated) before. The ADR and both PRs called for lockstep; the mechanism that actually enforces it is this pin, which merging the objectui PR does not touch. Range also carries objectui#2973 (modal actions are client-only) and eight other fixes since the last bump. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTTKgYriDB6RVrkYjxxnG1
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
size/s
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-blocking for v17. Found while auditing what ADR-0110 needs before the release goes out.
The problem
.objectui-shapinned4a4829d0ef39("chore: release packages (#2773)", bumped 2026-07-29). That commit is an ancestor of objectui#2970 — the ADR-0110 D1 client fix.build-console.shbuilds the shipped SPA at the pinned SHA, andreleaseruns it, so v17 would have shipped a console built before the fix.That console still posts
action.target || action.nameto/api/v1/actions/:object/:action. Against a v17 server:.../todo_task/completeTask)completeTaskEvery target-bound script action's button breaks in the shipped console — and it is a genuine regression, because that same request worked (ungated) before ADR-0110.
Why merging objectui#2970 was not enough
The ADR and both PRs called for lockstep, but the mechanism that actually enforces it is this pin. Merging the objectui PR moves objectui's
main; it does not touch.objectui-sha, andcheck:console-shaonly guards dist-vs-pin drift, not pin-vs-upstream staleness. Nothing would have caught this before release.What is in the range
4a4829d0ef39...a136322f8723— ten commits, including both ADR-0110 halves (#2970 D1 identity, #2973 modal actions are client-only) plus eight unrelated fixes that were already waiting to ship. Full list in the changeset.Per the release decision, the pin goes to objectui
mainHEAD rather than cherry-picking the two ADR-0110 commits onto a fresh tag — the rest of the range was going out anyway.Note on scope
Only
.objectui-shaand the changeset are committed here;packages/console/distis a gitignored, locally-built artifact that the release pipeline builds from the pin. After merging, a local checkout needspnpm objectui:build(rebuild at the pinned SHA) — notobjectui:refresh, which would re-bump to a local HEAD.🤖 Generated with Claude Code
https://claude.ai/code/session_01DTTKgYriDB6RVrkYjxxnG1
Generated by Claude Code