test(objectql): 补上运行时汇总字段修复的三个邻近路径 (#4427 后续) - #4428
Closed
os-zhuang wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
…ll-up fix #4427 made the summary index follow `registry.objectRevision` and pinned the headline path: an object registered after the index was already built. The same counter is responsible for three neighbouring behaviours it does not exercise, and each was independently broken before that fix: - re-registering an EXISTING object with a new summary field (the `update_metadata` incremental-authoring path — the object is already live, so this replaces a contributor rather than adding an object) - unregistering the parent, after which its roll-up must STOP being recomputed (the mirror of the bug: a stale index keeps writing to a parent that is gone) - the child's own insert already being correct, rather than a later write quietly repairing it — the property that made the original defect so slippery, since the no-op PATCH workaround always produced right answers Verified they earn their place: reverting #4427's `getSummaryDescriptors` change fails all three (roll-up `undefined`), alongside its own case. objectql 1504 tests pass; tsc clean. Test-only change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
xuyushun441-sys
force-pushed
the
fix/summary-index-invalidate-on-register
branch
from
August 1, 2026 05:10
27c37fb to
884bfc4
Compare
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
os-zhuang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
补什么
#4427 钉住了主路径：索引建好之后才注册的对象能算对。同一个 revision 计数器还负责另外三条邻近路径，那个 PR 都没有测到，而在修复前它们各自独立地坏着：
update_metadata增量编辑那条路。对象已经上线了，所以这走的是「替换已有 contributor」，不是「新增对象」。PATCH绕过办法每次都给出正确答案，于是很容易误判成「偶发」而不是「时序」。这些用例不是白写的
把 #4427 对
getSummaryDescriptors的改动回退掉，三个全部失败（roll-up 读到undefined），和它自己那个用例一起挂。恢复后 12/12 通过。tsc --noEmit干净summary-rollup.test.ts，无实现改动附：#4427 的修复在真机上确认有效
run-stack.sh --prod-like --seed跑同一句「项目任务管理」提示词，带负控制：两次子表数据都正常。（这份 E2E 是在 #4427 合并前、对等价实现跑的；机制相同。）
🤖 Generated with Claude Code