fix(plugin-list,plugin-form): 在注册表路径上把 dataSource 接到 list-view / embeddable-form (#3144) - #3147
Merged
Merged
Conversation
…ddable-form (#3144) `SchemaRenderer` 把 dataSource 放在 `SchemaRendererContext` 上,**从不**注入组件 props。所以任何从 `props.dataSource` 读取的组件,都需要注册处包一层把二者桥接起来。 `object-form` / `object-kanban` / `object-calendar` 一直都有这层。这两个没有: - `list-view`(以及 `view:list` 别名)直接注册裸 `ListView`,而 `ListView.tsx:585` 是 `const dataSource = props.dataSource` —— 于是取 object schema 的那个 effect 直接 return,永远不取数,渲染出 `data-testid="empty-state"` 的 "Nothing here"。 - `embeddable-form` 的渲染器是 `({ schema }) => <EmbeddableForm config={schema} />`, 把 context 整个丢了 —— 内层 ObjectForm 用来取字段的那个只读源(`formDataSource`) 永远构造不出来,而提交路径 `if (dataSource) await dataSource.create(...)` 也没东西 可调:公开表单会"提交成功"却什么都没写。 两者的 registry `inputs` 都把 `objectName` 标为 **required**。协议逼作者填、而这条 路径上没有任何东西读得到的绑定,就是 objectstack#4413 的形状往上挪了一层。之所以一直 没人报,是因为 console 走的不是这条路:它经 `ObjectView` 的 `renderListView` render-prop,由宿主自己把 dataSource 递进去。应用内是好的,注册表/SDUI 路径是坏的 ——而后者正是 sdui.manifest.json 描述的那份契约、`kind:'react'` 页面走的那条路。 发现自 `public-block-binding-reach.test.tsx`(objectstack#4472),不是人肉读出来的。 那个台账把这两条记为具名欠债;桥接一加上,台账的双向断言**立刻变红,直到条目被删掉** ——机制按设计工作。现在只剩 `record:related_list`,且是合理的。 显式传入的 `dataSource` prop 仍然优先,宿主自带数据源的用法不受影响; `ListViewRenderer` 用 forwardRef,`ListViewHandle` 经注册表仍可用。 验证:plugin-list / plugin-form / plugin-view 三个包 53 files / 662 tests 全绿; 两个包 `turbo type-check`(依赖已构建)clean;console 21 tests 全绿,其中把这两条塞回 台账会立刻变红("now reaches the data layer — delete its NO_DATA_REACH entry")。 Closes #3144 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S3cP1eY1novcNhQEDBrSZD
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
August 1, 2026 11:08
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3144。#3146(objectstack#4472 的检测手段)落地后的直接产物——那道门禁发现的两个真缺陷。
缺陷
SchemaRenderer把 dataSource 放在SchemaRendererContext上,从不注入组件 props(packages/react/src/SchemaRenderer.tsx:455的createElement里没有它)。所以任何从props.dataSource读取的组件,注册处都需要包一层把二者桥接起来。做了桥接的:
object-form、object-kanban、object-calendar——每个都注册了一个一行的 wrapper。没做的:
list-view(及view:list别名)ListView,而ListView.tsx:585是const dataSource = props.dataSource。取 object schema 的那个 effect 直接 return,永远不取数,渲染出data-testid="empty-state"的 "Nothing here"embeddable-form({ schema }) => <EmbeddableForm config={schema} />,把 context 整个丢了。内层 ObjectForm 取字段用的只读源(formDataSource)永远构造不出来;提交路径if (dataSource) await dataSource.create(...)也没东西可调——公开表单会"提交成功"却什么都没写两者的 registry
inputs都把objectName标为 required。协议逼作者填、而这条路径上没有任何东西读得到的绑定,就是 objectstack#4413 的形状往上挪了一层。为什么一直没人报:console 走的不是这条路——它经
ObjectView的renderListViewrender-prop,由宿主自己把 dataSource 递进去。应用内是好的,注册表/SDUI 路径是坏的,而后者正是sdui.manifest.json描述的那份契约、kind:'react'页面走的那条路。台账是被强制清掉的,不是被决定清掉的
public-block-binding-reach.test.tsx(#3146 引入)把这两条记为具名欠债。桥接一加上,台账的双向断言立刻变红:删掉条目才回绿。这正是那个双向检查存在的理由——没人被迫更新的台账,就是"接受的 baseline"的起点,而一份报告零分歧的 baseline 正是 objectstack#4413 得以出厂的原因。现在只剩
record:related_list一条,且合理(它要先从RecordContext拿到父记录 id 才允许取数,否则会列出整张子表)。兼容性
dataSourceprop 仍然优先(props.dataSource ?? context?.dataSource),宿主自带数据源的用法(ObjectView)不受影响。useContext而非useSchemaContext():后者在 provider 之外会抛异常,而裸挂载 + 宿主传源的用法必须继续可用。ListViewRenderer用forwardRef,ListViewHandle经注册表仍可用。验证
plugin-list/plugin-form/plugin-view:53 files / 662 tests 全绿turbo run type-check(依赖已构建)cleanapps/console:21 tests 全绿;把这两条塞回台账立刻变红(见上)🤖 Generated with Claude Code
https://claude.ai/code/session_01S3cP1eY1novcNhQEDBrSZD
Generated by Claude Code