Skip to content

fix(compliance): correct is_overdue_for_review date math — CEL has no Timestamp+int #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 19, 2026
Merged

fix(compliance): correct is_overdue_for_review date math — CEL has no Timestamp+int #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/compliance/src/objects/compliance_control.object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,15 @@ export const Control = ObjectSchema.create({
is_overdue_for_review: Field.formula({
label: 'Overdue for Review',
group: 'ownership',
expression: F`record.last_assessed_at == null || record.review_frequency_days == null || daysFromNow(0) > record.last_assessed_at + record.review_frequency_days * 86400000`,
// Overdue if never assessed, or the next-review date (last assessment +
// review_frequency_days) is already in the past. The formula engine is CEL:
// dates are Timestamps and there is NO `Timestamp + int` operator, so day
// arithmetic must go through the `addDays(date, n)` builtin (Timestamp
// comparison with `<` is supported). The old `last_assessed_at +
// review_frequency_days * 86400000` silently evaluated to null for every
// assessed control (no `+` on Timestamp), so only never-assessed controls
// ever flagged — a stale-but-assessed control (e.g. GDPR Art.32) was missed.
expression: F`record.last_assessed_at == null || record.review_frequency_days == null || addDays(record.last_assessed_at, record.review_frequency_days) < today()`,
}),
notes: Field.markdown({ label: 'Notes', group: 'meta' }),

Expand Down
Loading