fix(email): a11y + mobile/UX correctness polish - #358
Open
DiogoDuart3 wants to merge 5 commits into
Open
Conversation
…weep, contrast, dehydration bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch of small, independent a11y and correctness fixes to the webmail client, verified live via a headless login + screenshot pass at 1280px and 390px before/after each change.
Mobile / correctness
lg:hidden) to avoid overlapping the sidebar's own persistent "New email" trigger.mdand the action row getsoverflow-x-auto- the label was the one item wide enough to push the "..." menu off the right edge on a phone-width screen.0rendering next to the subject on a single-message thread:totalEmails && totalEmails > 1 && ...-0 && xevaluates to0, and unlikefalse/null/undefined, React renders a numeric0as text. Switched to a ternary."Re: Design review feedback"->"Subject".getAppUrl()now readswindow.location.originat runtime consistently across all redirect call sites) - the client is an SPA served same-origin, so there's no reason a redirect should ever reference a build-time value.+character sitting before a<button>tag inrender-labels.tsx(pre-existing, not introduced by this PR) - valid JSX syntax so it doesn't break the build, but it gives aTooltipTrigger asChildtwo children instead of one, which Radix'sSlot(React.Children.only) will throw on at runtime for any label with a visible tooltip.Accessibility (Lighthouse-driven)
Collapsiblewrapper around sidebar nav items that never had a matchingCollapsibleContent- left a danglingaria-controlsreference (aria-valid-attr-value) and put a non-<li>wrapper directly inside<ul data-sidebar="menu">(invalid list semantics,aria-required-children).<main>landmark around the mail app's primary content region.aria-allowed-attr: two*Trigger asChildsites were injectingtype="button"/aria-haspopuponto bare<div>s with no interactive role - invalid. Converted to real<button>s.button-name: addedaria-labelto icon-only buttons across the mail list, thread view, sidebar, and composer (mostly reusing existing tooltip copy).text-[#8C8C8C](fails ~3.36:1 on light backgrounds) now falls back throughtext-muted-foregroundwithdark:text-[#8C8C8C]for the dark-mode accent. Darkened the#006FFEbrand blue to#0062D4for the two buttons pairing it with white text (was ~4.46:1, just under the 4.5:1 minimum). Dropped anopacity-70utility on list-row timestamps that dilutedtext-muted-foregroundbelow 4.5:1 at rest in both themes (full opacity only kicked in on hover/select).Uncaught (in promise)console error (12-17x per session): the IndexedDB query-persister'sshouldDehydrateQueryhad dropped TanStack Query's default "only persist settled queries" check. In-flight queries still carry a livePromisefield when dehydrated, whichIndexedDB's structured-cloneput()cannot serialize - throwingDataCloneErroron nearly every persist right after login. Restored the missing status check.Note on CI
Recent merged PRs against
main(#322, #327) showTypecheck: SUCCESS/Test: FAILUREon their PR-context runs. Flagging in case it reproduces here too - doesn't look related to this change.