fix(dashboard): enable rollback for success-mapped deployment rows - #414
Open
santhiprakash wants to merge 1 commit into
Open
fix(dashboard): enable rollback for success-mapped deployment rows#414santhiprakash wants to merge 1 commit into
santhiprakash wants to merge 1 commit into
Conversation
- Problem: mapRowToDeployment normalizes API `ready` to list status `success`, but DeploymentMenu only gated rollback/pin on `ready`, so every finished deploy stayed disabled. - Fix: centralize rollback eligibility in isDeploymentRollbackEligible and use it for rollback + pin affordances. - Verification: bun run --cwd apps/dashboard test src/utils/project-status.test.ts (11 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #410
Problem
On the deployments list, finished deploys show status
successbecausemapRowToDeploymentnormalizes the API's terminalreadyvalue for display/filtering.DeploymentMenuonly enabled Rollback and Pin whendeployment.status === "ready", socanRollbackwas always false for normally completed deployments — even when the row showed the Snapshotted chip and had a retained artifact or commit SHA.Triage / Root cause
ready(deployment-lifecycle.ts).ready → successinapps/dashboard/src/app/(dashboard)/deployments/utils.ts.DeploymentMenu.tsxstill checked only forready.Fix
isDeploymentRollbackEligible()beside the status map inutils.ts, acceptingready,success, andpartial_failure.DeploymentMenu.tsx.Verification
bun run --cwd apps/dashboard test src/utils/project-status.test.ts11 tests passed, including new coverage that a
readyAPI row mapped tosuccessis rollback-eligible.Notes / Risks
rollbackDeployment()was already ungated.