Repository navigation
feat(gate): move the directly mounted scanner to Preact - #54
Merged
Merged
Conversation
Signed-off-by: yujiym <1409395+yujiym@users.noreply.github.com>
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Move fuda's frontends to Preact through the owner's
void-preactadapter because they consider it the most promising structure and want fuda to dogfood their library.This layer stacks on #53 and ports gate first. Gate keeps its direct
index.htmlmount and Worker verification. The pages adapter arrives with dash because gate has no pages APIs to consume.What changed
actDOM helper. Share the existing camera loop, labels, and prop types through renderer-independent UI subpaths.Scope
Gate and its consumed shared UI only. Dash and app continue using Solid. There are no changes to API contracts, e2e assertions, deployment configuration, or ADR 0015. The new runtime and preset are older than the three-day release window, so no additional age exemption is needed.
Blast Radius
Both renderers consume the shared Scanner labels and camera module. The camera lifetime itself is unchanged from #53. Full workspace checks and all unchanged e2e cases cover coexistence. The gate, Vite+, preset, Prefresh, and prerender Vite imports have identical module identity; the workspace retains its two existing YAML peer contexts of Vite+ core 0.3.0. Existing peer-version warnings remain.
Verification
All commands use
mise x node@24 -- corepack pnpm.install --frozen-lockfile,check,test,fallow:audit, ande2eall exit 0.checkreports all 855 files formatted and no lint or type issues in 1,026 files.testpasses 2,442 Vitest tests and 70 Solidity tests. Gate has 50 tests and ui-preact has 10.fallow:auditreports zero new dead code, complexity, or duplication findings.e2epasses all 19 unchanged cases. The seven unchanged gate cases also pass separately against its production Worker and the built local API Worker.Local logs, saved client outputs, scripts, screenshots, and measurement details are under
artifacts/2026-11-05-preact-migration/gate/in the main checkout. Generated localvoid.lock.jsonvalues were restored.Deploy and manual checks
No deployment was performed. All local servers and browser tabs were stopped. WebKit is not installed at
/tmp/fuda-pw, so its check is skipped. A real camera and NETUM reader remain owner checks.