fix(cli): honor Chrome extra args on start#37
Open
anupamchugh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35.
Problem
chrome-ws startbuilt its Chrome launch args inline, so it ignored the documentedCHROME_EXTRA_ARGSenvironment variable. That meant headless/root Linux users could not pass flags such as--headless=newor--disable-gputhrough the CLI start path, even though the MCP/library launch path already honored those flags.Change
buildChromeArgs()helper inchrome-ws start.chromeHeadless: false.Verification
node --test test/cli-dispatch.test.mjspassed: 5/5.npm testpassed: lint clean, bundle fresh, 435/435 tests passing.Review
Anupam Chugh reviewed the complete diff in chat before submission. The diff is scoped to two files and does not add dependencies or unrelated refactors.
Notes
This repo currently has
mainas its default branch and no remotedevbranch, so this PR targetsmain.