Repository navigation
feat: default snap icon from the org avatar, overridable per repo - #11
Closed
astrojuanlu wants to merge 2 commits into
Closed
astrojuanlu wants to merge 2 commits into
astrojuanlu wants to merge 2 commits into
Conversation
Repos that ship their own snap/meta/gui/icon.png keep it; otherwise the pack job fetches the obs-plugins-snaps org avatar before packing, so store listings get a real icon out of the box. Assisted-by: OpenRouter:z-ai/glm-5.3-flash pi
The template now ships the icon at snap/gui/icon.png and renders icon: snap/gui/icon.png; meta/gui is only the in-snap install layout that snapcraft generates, not a required repo path. Assisted-by: OpenRouter:z-ai/glm-5.3-flash pi
Contributor
Author
|
Aligned ( Assisted-by: OpenRouter:z-ai/glm-5.3-flash pi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pack job now injects a default icon when the repo does not ship one:
snap/meta/gui/icon.pngexists (repo override) → keep it.obs-plugins-snapsorg avatar (PNG, 256px) intosnap/meta/gui/icon.pngbefore packing.Verified: org id 311047717 serves
image/png(~15 kB).Note
The
icon:key itself lands via template (snapcraft.yaml rendersicon: meta/gui/icon.png); this workflow change makes every buildsucceed once that key exists. Merge after the template change or in any
order - until the template adds the key, the fetched file is inert.
Assisted-by: OpenRouter:z-ai/glm-5.3-flash pi