You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
rust: Port libobs/obs-encoder-align-frame-rate-divisor.c.h to obs-output #5331
Phase 6 Rust swap of libobs/obs-encoder-align-frame-rate-divisor.c.h into obs-output, after prerequisite #5314 lands. The prerequisite extracts the C body without behavioral changes and adds test_encoder_align_frame_rate_divisor with its canonical graph registration.
Preserve the no-call guards for NULL encoder/media and divisor below two. Otherwise forward exactly once to video_output_align_frame_rate_divisor with the original media, full uint64 timestamp, encoder pointer and EXACT receive_video address used by raw-video registration. The C prerequisite keeps a static declaration in the same O unity group; a Rust swap must expose the real callback address through an internal C seam, rather than inventing another callback. Keep libobs-owned media/encoder lifetime and existing locking behavior.
Port all characterization assertions to safe Rust Tier 1, add the thin ABI shim and real field/callback seam, retain the unchanged source-only C fixture as an oracle and add equivalent external Rust boundary coverage for Tier 2, and add the original C oracle plus Tier 3 randomized differential and mutation coverage. The existing C fixture uses real video-io registration and callback+param lookup, with decoys that differ in just one identity component; preserve that proof. Network Tier 4 does not apply.
Use the shared Rust-static support infrastructure from #5246, never a placeholder or aborting stub. Build EVERY configured Linux *_rust consumer, run the whole native_build:: module, and check both Windows MSVC and Darwin arm64 links. The swap must wait for #5314 and #5246; do not combine it with encoder output-slot extraction work. Public headers and existing C tests remain unchanged.
Prerequisite publication is currently BRANCH-ONLY because ci/backpressure.py returned 75 (runner starvation). Validated and pushed head: d48d033 on test/5314-encoder-align-divisor. No prerequisite PR was opened. Wait for #5314 to be published and merged before starting this swap.
The final C fixture also gives its decoy callback a distinct observable body, protecting its address-based assertions against identical-code folding. Carry that property into any new external Rust boundary fixture. Source-only characterization is not sufficient Tier 2 coverage for the later swap.
Activity
zackees commentedon Nov 20, 2026
Claiming: Rust swap of encoder frame-rate divisor alignment in pool slot obs-studio2, branch port/5331-encoder-align-divisor.